search

terraform-aws-modules / terraform-aws-batch

Terraform module to create AWS Batch resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/batch/aws
Apache License 2.0
35 stars 40 forks source link

fix: Fargate example #23

Closed akoshel closed 8 months ago

akoshel commented 10 months ago

Subject: Fixing Fargate Example

Description:

Hello there,

I encountered an issue with the Fargate example in the project where it failed to work as expected. I've made several changes that resolved the issue for me and allowed the example to function properly.

Kindly review and consider merging these adjustments. Thank you!

bryantbiggs commented 10 months ago

can you provide more details on what failed, any error messages, how to reproduce, etc.? I'll try deploying the examples we have later but this did work at one point in time

akoshel commented 10 months ago

I couldn't save the errors this time. I'll make an attempt to reproduce them in the next few days.

However, I'd like to bring up a few points for consideration:

  1. It appears that the 'instance_iam_role_name' might not be required in the Fargate example, causing confusion.
  2. I included 'jobRoleArn' in the JobDefinition since it seems necessary in most scenarios.
akoshel commented 10 months ago

Hi @bryantbiggs Just reproduced original example and it works. Seems like I had another issues before I left my PR open with following fixes. I think it could be helpful

  1. Added jobRoleArn to JobDefinition
  2. Removed instance_iam_role and spot_fleet_iam_role (Fargate example works without this roles)

If you think that this changes is not needed you can close PR Thanks

bryantbiggs commented 10 months ago

Just reproduced original example and it works.

I'm sorry but I'm not following - are you saying that the example is working as intended now or you were able to reproduce the issue(s) you were experiencing with the example?

github-actions[bot] commented 9 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

bryantbiggs commented 8 months ago

closing this for now

github-actions[bot] commented 7 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.