fix: Rename launch template parameters

darhsu commented 9 months ago

Description

A user can set their launch_template_id parameter by using id or launch_template_id.
A user can set their launch_template_name parameter by using name or launch_template_name.

Motivation and Context

Renaming these parameters to align with the aws_batch_compute_environment resource found here.
Using the id and name parameters is a little confusing as it is not consistent with the aws_batch_compute_environment resource.
Other parameters in this module use the same naming convention as the aws_batch_compute_environment resource.

Breaking Changes

This change is backwards compatible.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

antonbabenko commented 8 months ago

This PR is included in version 2.0.2 :tada:

github-actions[bot] commented 7 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-batch