fix: Job definition is always recreated when attempt_duration_seconds is null

terraform-aws-modules / terraform-aws-batch

Terraform module to create AWS Batch resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/batch/aws

Apache License 2.0

35 stars 40 forks source link

fix: Job definition is always recreated when attempt_duration_seconds is null #28

Closed joanayma closed 4 months ago

joanayma commented 6 months ago

Description

When a job definition in the module parameter job_definitions has not set attempt_duration_seconds it always shows a drift between what terraform has set and what AWS returns.

Motivation and Context

The job definition is not recreated after this change.

Breaking Changes

None.

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

github-actions[bot] commented 5 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 4 months ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.