fix: Use maps for IAM additional policies used in for_each

mattaltberg commented 6 months ago

Description

Fixes the error involving the for_each loops for any additional_iam_policies, mentioned in stale issue https://github.com/terraform-aws-modules/terraform-aws-batch/issues/15

Motivation and Context

Fixes stale issue https://github.com/terraform-aws-modules/terraform-aws-batch/issues/15

Breaking Changes

Yes, as it will change the input type for a few IAM policy lists. The change is necessary, because for_each requires maps when the values are dynamic. Otherwise the keys will not work

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request
[x] I have tested the changes on my own infra by updating the downloaded module code

mattaltberg commented 6 months ago

@bryantbiggs are you around for this fix?

github-actions[bot] commented 5 months ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

github-actions[bot] commented 4 months ago

This PR was automatically closed because of stale in 10 days

github-actions[bot] commented 3 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-batch