search

terraform-aws-modules / terraform-aws-batch

Terraform module to create AWS Batch resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/batch/aws
Apache License 2.0
35 stars 41 forks source link

Update Syntax for `compute_environments` #30

Closed schammah closed 2 months ago

schammah commented 4 months ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Is your request related to a problem? Please describe.

 on .terraform/modules/batch/main.tf line 231, in resource "aws_batch_job_queue" "this":
│  231:   compute_environments  = slice([for env in try(each.value.compute_environments, keys(var.compute_environments)) : aws_batch_compute_environment.this[env].arn], 0, min(length(try(each.value.compute_environments, keys(var.compute_environments))), 3))
│
│ This parameter will be replaced by `compute_environment_order`.

Describe the solution you'd like.

Update the resource to compute_environment_order

Additional context

Current Parameter will be deprecated soon, written also in the official doc

github-actions[bot] commented 3 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

schammah commented 3 months ago

@antonbabenko , does this makes sense?

bryantbiggs commented 3 months ago

it makes sense, but its a breaking change. right now its just a warning that the argument will be removed in the next major version - is there an issue that you are running into?

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 2 months ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 month ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.