search

terraform-aws-modules / terraform-aws-batch

Terraform module to create AWS Batch resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/batch/aws
Apache License 2.0
35 stars 40 forks source link

Values for "VCPU" and "MEMORY" should be strings instead of numbers #4

Closed ehtung closed 2 years ago

ehtung commented 2 years ago

https://github.com/terraform-aws-modules/terraform-aws-batch/blob/b0b3857399c5030d4c34519f363be1abb789dd59/examples/fargate/main.tf#L132

Having numbers as values for VCPU and MEMORY like in this example will cause:

Error: AWS Batch Job container_properties is invalid: Error decoding JSON: json: cannot unmarshal number into Go struct field ResourceRequirement.ResourceRequirements.Value of type string
bryantbiggs commented 2 years ago

I'm not sure if there were any provider level changes since this was published but the example provided used to work. Regardless, its an easy fix to just wrap the numeric values in quotes - no changes are required to the module definition

ehtung commented 2 years ago

Agreed @bryantbiggs, change (the wrap) needed in the example only.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 2 years ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.