chore: Correct resourceRequirements in Fargate example

terraform-aws-modules / terraform-aws-batch

Terraform module to create AWS Batch resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/batch/aws

Apache License 2.0

35 stars 40 forks source link

chore: Correct resourceRequirements in Fargate example #6

Closed dex4er closed 2 years ago

dex4er commented 2 years ago

It fixes 2 bugs:

Error: AWS Batch Job container_properties is invalid: Error decoding JSON: json: cannot unmarshal number into Go struct field ResourceRequirement.ResourceRequirements.Value of type string

and

Error: error creating Batch Job Definition (batch-ex-fargate): : Error executing request, Exception : Fargate resource requirements (1.00 vCPU, 1024 MiB) not valid.,

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

dex4er commented 2 years ago

I think it fixes #4

antonbabenko commented 2 years ago

There seems to be an issue in the Terraform AWS provider - https://github.com/hashicorp/terraform-provider-aws/issues/14024 .

For the time being, we can merge this PR if it works. Could you please run it to confirm that it works AND put a comment referring to the provider issue (link above) right in the code, so that users can track it in the future.

Thank you!

dex4er commented 2 years ago

@antonbabenko I don't understand. Your provider issue is about missing container_properties attribute. My error message was about invalid JSON schema (parameters must be strings, not a numbers) so I don't believe it is an error in the provider.

And my patch works. Currently I use it in my Terraform workspace.

antonbabenko commented 2 years ago

Ok, let's merge this PR then. Thank you!

antonbabenko commented 1 year ago

This PR is included in version 1.2.1 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.