Allow for custom KMS key encryption on bucket created instead of standard AES256

terraform-aws-modules / terraform-aws-datadog-forwarders

Terraform module to create resources on AWS to forward logs/metrics to Datadog 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/datadog-forwarders/aws

Apache License 2.0

56 stars 40 forks source link

Allow for custom KMS key encryption on bucket created instead of standard AES256 #10

Closed bryantbiggs closed 2 years ago

bryantbiggs commented 3 years ago

Is your feature request related to a problem? Please describe.

Using AWS default encryption key is generally discouraged, best practice is to use customer-managed keys, therefore it would be great if the module would allow specifying a customer-managed key. Ref: tfsec.dev/docs/aws/s3/enable-bucket-encryption

Describe the solution you'd like Ability to provide a CMK for bucket encryption

Describe alternatives you've considered None

Additional context From convo on #9

bryantbiggs commented 2 years ago

:tada: This issue has been resolved in version 3.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.