search

terraform-aws-modules / terraform-aws-datadog-forwarders

Terraform module to create resources on AWS to forward logs/metrics to Datadog 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/datadog-forwarders/aws
Apache License 2.0
55 stars 41 forks source link

Create Lambda trigger for RDS EM forwarder #19

Closed edjshelton closed 1 year ago

edjshelton commented 2 years ago

Is your request related to a new offering from AWS?

No

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Is your request related to a problem? Please describe.

The RDS enhanced metrics forwarder module doesn't create the Lambda trigger for sending metrics from the RDSOSMetrics CloudWatch log group.

Describe the solution you'd like.

Add a the trigger as either a subscription filter on the log group or a trigger on the Lambda function.

Describe alternatives you've considered.

We've had to Terraform the trigger/filter separately, but there's no obvious reason why it can't be included in this module.

Additional context

Basically step 11 on the installation docs onwards:

https://docs.datadoghq.com/integrations/amazon_rds/?tab=enhanced#installation

lukedoesinfra commented 2 years ago

@bryantbiggs - Could you explain the position of not adding the trigger in the above context when you have a second? Thanks

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.