terraform-aws-modules / terraform-aws-datadog-forwarders

Terraform module to create resources on AWS to forward logs/metrics to Datadog 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/datadog-forwarders/aws
Apache License 2.0
56 stars 40 forks source link

Bump s3_module version to 3.1.0 or newer #27

Closed nikola197 closed 1 year ago

nikola197 commented 1 year ago

Description

I updated AWS provider version for my Terraform project from 3.75.2 to 4.9.0 and warning started appearing.

│ Warning: Argument is deprecated │ │ with module.my_module.module.datadog_log_forwarder.module.datadog_log_forwarder.module.this_s3_bucket.aws_s3_bucket.this, │ on .terraform/modules/my_module.datadog_log_forwarder.datadog_log_forwarder.this_s3_bucket/main.tf line 14, in resource "aws_s3_bucket" "this": │ 14: resource "aws_s3_bucket" "this" { │ │ Use the top-level parameter object_lock_enabled and the aws_s3_bucket_object_lock_configuration resource instead

There are newer versions of terraform-aws-s3-bucket module, starting with 3.1.0, that fixed said warning.

Versions

Reproduction Code [Required]

Steps to reproduce the behavior:

Are you using workspaces? No. Have you cleared the local cache (see Notice section above)? Yes. List steps in order that led up to the issue you encountered: terraform init terraform plan terraform apply -auto-approve

Expected behavior

Terraform plan and apply executed without the warning.

Actual behavior

Terraform plan and apply executed with the described warning.

bryantbiggs commented 1 year ago

closed in #29

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.