feat!: Update S3 module to v3.6.1 and switch to resource aws_s3_object

michemache commented 1 year ago

Description

Updated module terraform-aws-s3-bucket to v3.6.1 to remove the warnings about deprecated attributes.
Switch from resource aws_s3_bucket_object to aws_s3_object to remove the warnings about deprecated arguments.

Motivation and Context

We got the following warnings during deploying the Datadog log forwarder: ``` ╷ │ Warning: Deprecated attribute │ │ on .terraform/modules/datadog_integration.this_s3_bucket/main.tf line 34, in resource "aws_s3_bucket" "this": │ 34: acceleration_status, │ │ The attribute "acceleration_status" is deprecated. Refer to the provider │ documentation for details. │ │ (and 4 more similar warnings elsewhere) ╵ ╷ │ Warning: Argument is deprecated │ │ with module.datadog_integration.aws_s3_bucket_object.this[0], │ on .terraform/modules/datadog_integration/modules/log_forwarder/main.tf line 134, in resource "aws_s3_bucket_object" "this": │ 134: bucket = var.create_bucket ? module.this_s3_bucket.s3_bucket_id : var.bucket_name │ │ Use the aws_s3_object resource instead │ │ (and one more similar warning elsewhere) ╵ ```

and also see Issue: https://github.com/terraform-aws-modules/terraform-aws-datadog-forwarders/issues/27

Breaking Changes

Upgrade the S3 module to v3.3.1 and newer requires minimum v4.9 of the AWS provider

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

antonbabenko commented 1 year ago

This PR is included in version 5.0.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-datadog-forwarders