terraform-aws-modules / terraform-aws-datadog-forwarders

Terraform module to create resources on AWS to forward logs/metrics to Datadog 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/datadog-forwarders/aws
Apache License 2.0
55 stars 41 forks source link

Support AWS Provider v5 - aws_s3_object acl default value changed to null instead of private #34

Closed nikola197 closed 1 year ago

nikola197 commented 1 year ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Is your request related to a problem? Please describe.

Description

I encountered an error with Terraform AWS provider v4 -> v5 upgrade.

Change that Terraform want to make:

module.datadog_log_forwarder.aws_s3_object.this[0] will be updated in-place
  ~ resource "aws_s3_object" "this" {
      - acl                    = "private" -> null
        id                     = "aws-dd-forwarder-3.71.0.zip"
        tags                   = {
            "DD_FORWARDER_VERSION" = "3.71.0"
        }
        # (14 unchanged attributes hidden)
    }

Error for previous plan:

╷ │ Error: putting S3 object ACL: MissingSecurityHeader: Your request was missing a required header │ status code: 400 │ │ with module.datadog_log_forwarder.aws_s3_object.this[0], │ on .terraform/modules/datadog_log_forwarder.datadog_log_forwarder/modules/log_forwarder/main.tf line 131, in resource "aws_s3_object" "this": │ 131: resource "aws_s3_object" "this" { │ ╵

Describe the solution you'd like.

Set acl = "private" for aws_s3_object.this[0]

Additional context

Terraform AWS Provider Version 5 Upgrade Guide

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 11 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.