fix: Change default runtime to python3.11 to support latest forwarder version

terraform-aws-modules / terraform-aws-datadog-forwarders

Terraform module to create resources on AWS to forward logs/metrics to Datadog 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/datadog-forwarders/aws

Apache License 2.0

55 stars 41 forks source link

fix: Change default runtime to python3.11 to support latest forwarder version #37

Closed gpdenny closed 7 months ago

gpdenny commented 7 months ago

Description

Follow up from #36. Believe the default runtime needs to be python3.11 to support version 3.103.0 of the forwarder. Otherwise runs into https://github.com/urllib3/urllib3/issues/2168

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

gpdenny commented 7 months ago

should this be changed throughout?

https://github.com/terraform-aws-modules/terraform-aws-datadog-forwarders/blob/49dd34138515d41b0bb1b4ba8328ec1c32f9629e/modules/log_forwarder/variables.tf#L203

doh :facepalm: Yes, my bad didn't consider the case for using the sub-modules directly.

antonbabenko commented 7 months ago

This PR is included in version 6.0.1 :tada:

github-actions[bot] commented 6 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.