tennengabr
commented
2 months ago @Darwiner I was also confused by this as was brought into the implementation half way through process. After reading the docs on which the module is based on (datadog-serverless-functions/aws/log_monitoring).
It appears you can either create the triggers manually using the variables exported from this module or Datadog will create them for your automatically when you setup your Datadog integrations.
Here is more information on setting up the triggers using automatic/manual approaches. Send AWS Services Logs With The Datadog Lambda Function - Set up triggers
Description
This might be halfway between a "bug" (because of the description) and a feature request at the same time...
The
s3_log_bucket_arnsvariable in https://github.com/terraform-aws-modules/terraform-aws-datadog-forwarders/tree/master/modules/log_forwarder has a description that mentions:...yet, looking through the code (and also trying it out), is it possible that it does not take care of adding the actual forwarding of logs to Datadog?
I was expecting to see a
aws_s3_bucket_notificationresource, which I believe would have taken care of this part, but there does not seem to be one? Or might I be missing something?Versions
Module version [Required]: 6.0.1
Terraform version: 1.8.3
Provider version(s):
provider registry.terraform.io/datadog/datadog v3.39.0
provider registry.terraform.io/hashicorp/aws v5.49.0
provider registry.terraform.io/hashicorp/null v3.2.2
provider registry.terraform.io/hashicorp/random v3.6.1
Expected behavior
Lambda function being aware of new logs in S3 bucket and forwarding those to Datadog. Lambda logs/metrics showing activity. New logs appearing in Datadog.
Actual behavior
S3 logs are not getting forwarded by the lambda function. Lambda function logs are empty. Nothing appearing in Datadog logs.