feat: DMS endpoint credential from secret manager

[vigneshwar-rajkumar-vineti]

AWS DMS endpoint resource now(https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/dms_endpoint#secrets_manager_access_role_arn) supports getting credentials from secret manager.

Description

AWS DMS endpoint resource now(https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/dms_endpoint#secrets_manager_access_role_arn) supports getting credentials from secret manager. This two line change allows users of the module to configure the DMS credentials from the secret manager.

secrets_manager_arn = lookup(each.value, "secrets_manager_arn", null) secrets_manager_access_role_arn = lookup(each.value, "secrets_manager_access_role_arn", null)

Motivation and Context

Getting credentials from secret manager for DMS is particularly useful when the database credentials has special characters which RDS supports but the DMS does not support.

Breaking Changes

How Has This Been Tested?

• [x] I have tested and validated these changes using one or more of the provided examples/* projects. I have tested the changes from my local branch.

[bryantbiggs]

Thanks for the PR @vigneshwar-rajkumar-vineti - we'll need to update the minimum supported version of the AWS provider for this change

[vigneshwar-rajkumar-vineti]

@bryantbiggs Thank you for the review. Is that something that can be done at this time ? Also Can I update this PR with the minimum supported version.

[bryantbiggs]

@vigneshwar-rajkumar-vineti yes, it should be made with this PR since its required by the change made here

[github-actions[bot]]

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

[github-actions[bot]]

This PR was automatically closed because of stale in 10 days

[ramonPires]

Hi @vigneshwar-rajkumar-vineti , are you still working in the changes required by @bryantbiggs ? Because a new issue were opened related to this topic https://github.com/terraform-aws-modules/terraform-aws-dms/issues/23 , and I think this pull request will be the solution. If you are not working on it or dont need it anymore I can open a new pull request with this feature and requirements from @bryantbiggs .

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.