fix: correct usage of `*_settings` blocks within `aws_dms_endpoint` resource

terraform-aws-modules / terraform-aws-dms

Terraform module to create AWS DMS (Database Migration Service) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/dms/aws

Apache License 2.0

64 stars 96 forks source link

fix: correct usage of `*_settings` blocks within `aws_dms_endpoint` resource #2

Closed bryantbiggs closed 3 years ago

bryantbiggs commented 3 years ago

Description

correct usage of *_settings blocks within aws_dms_endpoint resource
update example to validate/show using S3 as a source destination with the s3_settings block functioning as intended

Motivation and Context

ensure module functionality works as intended

How Has This Been Tested?

example/complete has been updated and validated with this change

Screenshots (if appropriate):

bryantbiggs commented 3 years ago

:tada: This PR is included in version 1.0.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.