fix: Replace local-exec sleep with time_sleep

tzfromaz commented 2 years ago

Description

Replace local-exec sleep with time_sleep to wait for dependency resources to get created and destroyed properly.

Motivation and Context

As per: https://github.com/hashicorp/terraform-provider-aws/issues/11025#issuecomment-660059684, using local-exec sleep was a temporary fix, time_sleep is more suited for specifically managing cross-platform compatibility and destroy-time issues.

Breaking Changes

N/A

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

CC: @antonbabenko

tzfromaz commented 2 years ago

Does anyone know how I can fix the MAX TF pre-commit hook: https://github.com/terraform-aws-modules/terraform-aws-dms/runs/7408469458?check_suite_focus=true? I am not sure what I need to change to pass this check.

bryantbiggs commented 2 years ago

you'll need to add the time provider to the required providers block and then run pre-commit run -a and fix all the checks to pass

tzfromaz commented 1 year ago

Do you know when this will be reviewed by? @bryantbiggs

antonbabenko commented 1 year ago

This PR is included in version 1.5.3 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-dms