terraform-aws-modules / terraform-aws-dms

Terraform module to create AWS DMS (Database Migration Service) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/dms/aws
Apache License 2.0
60 stars 93 forks source link

feat: Added support for secretsmanager secret in endpoints #27

Closed Kostavro closed 1 year ago

Kostavro commented 1 year ago

Description

Adding the ability to configure aws_dms_endpoint database connection details via a SecretsManager secret. Reference: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/dms_endpoint#secrets_manager_access_role_arn

Motivation and Context

This is supported in the Terraform provider and provides a nice way to securely pass the database connection details. AWS documentation:

Breaking Changes

No breaking changes.

How Has This Been Tested?

Kostavro commented 1 year ago

@antonbabenko Could you please help me understand what you mean?

I am not introducing any extra resources to the module, but just introducing new optional arguments in the same way as the rest of the optional arguments in the aws_dms_endpoint resource.

I am only introducing extra resources in the example, to show how the secret functionality can be used (which I think is what you are also suggesting). I have also ran and tested the updated example, and ran this branch's configuration with my own test as well, so I am confident it works as intended.

Seeing as there are no new resources and no major changes to any of the existing ones, and nor are there any new variables, I am not sure what would you like the README in the root to say - perhaps a short excerpt of how to use this possible configuration for an endpoint?

Kostavro commented 1 year ago

Thanks @antonbabenko ! Pushed a new commit to bump the AWS provider, please review :)

antonbabenko commented 1 year ago

This PR is included in version 1.6.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.