Enable the usage of Secrets Manager Credentials with Compatible RDS Targets

terraform-aws-modules / terraform-aws-dms

Terraform module to create AWS DMS (Database Migration Service) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/dms/aws

Apache License 2.0

64 stars 96 forks source link

Enable the usage of Secrets Manager Credentials with Compatible RDS Targets #28

Closed chtakahashi closed 2 years ago

chtakahashi commented 2 years ago

Description

Some RDS sources are compatible with secrets manager for login credentials. This PR enables the usage of that (addresses https://github.com/terraform-aws-modules/terraform-aws-dms/issues/23).

Motivation and Context

We wanted to be able to use this module in tandem with secrets manager authentication to RDS databases.

Breaking Changes

None. This doesn't add new variables, just enables the use of 2 new keys within the endpoints variable.

How Has This Been Tested?

Running this in our own infrastructure

chtakahashi commented 2 years ago

I sat on this for too long! This got addressed 3 days ago in https://github.com/terraform-aws-modules/terraform-aws-dms/pull/27 :) Thank you!

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.