feat: add new `kafka_settings` attributes for DMS endpoint, and add `cdc_start_position` to DMS replication task

terraform-aws-modules / terraform-aws-dms

Terraform module to create AWS DMS (Database Migration Service) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/dms/aws

Apache License 2.0

62 stars 94 forks source link

feat: add new `kafka_settings` attributes for DMS endpoint, and add `cdc_start_position` to DMS replication task #3

Closed bryantbiggs closed 2 years ago

bryantbiggs commented 2 years ago

Description

add new kafka_settings attributes to the DMS endpoint resource that were added upstream in the AWS provider https://github.com/hashicorp/terraform-provider-aws/pull/20904
add new attribute cdc_start_position to the DMS replication task resource that were added upstream in the AWS provider https://github.com/hashicorp/terraform-provider-aws/pull/21201
bump minimum version of AWS provider to v3.62.0 to support these additions

Motivation and Context

additional functionality that was added to upstream provider

How Has This Been Tested?

complete example has been updated and validated

Screenshots (if appropriate):

bryantbiggs commented 2 years ago

waiting on error resolution for

 Error: 1 error occurred:
│   * kafka_settings must be set when engine_name = "kafka"
│ 
│   with module.dms_aurora_postgresql_aurora_mysql.aws_dms_endpoint.this["kafka-destination"],
│   on ../../main.tf line 141, in resource "aws_dms_endpoint" "this":
│  141: resource "aws_dms_endpoint" "this" {
│ 
╷
│ Error: 1 error occurred:
│   * s3_settings must be set when engine_name = "s3"
│ 
│   with module.dms_aurora_postgresql_aurora_mysql.aws_dms_endpoint.this["s3-source"],
│   on ../../main.tf line 141, in resource "aws_dms_endpoint" "this":
│  141: resource "aws_dms_endpoint" "this" {

bryantbiggs commented 2 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.