fix: Update aws provider version to restore support for ignore_header_row

[scadu]

Description

Terraform provider in version 4.49.0 gets a fix that allows setting IgnoreHeaderRows, with a fallback on ignore_header_row besides ignore_header_rows. In version 5.0.0 of the provider, the fallback is removed and there are many other breaking changes that affects this module and underlying VPC module.

Motivation and Context

Fixes https://github.com/terraform-aws-modules/terraform-aws-dms/issues/38

Breaking Changes

How Has This Been Tested?

• [x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
• [x] I have tested and validated these changes using one or more of the provided examples/* projects
• [x] I have executed pre-commit run -a on my pull request

[scadu]

I have no idea why the PR title action fails, even though the title is fine. Looks like the fix prefix isn’t detected for some reason.

[byjg]

How do I use your PR in my code?

[scadu]

How do I use your PR in my code?

You can pin aws provider in your project with the same constraints as in the PR.

[byjg]

So, I checked the PR files and I realized there is no fix for the Ignore Rows itself, but limiting the terraform to 5.0. I have other terraform-aws they already upgraded the constraints to >5.0.0 and that force me to move to a newer version.

Anyway, thanks for the prompt answer.

[scadu]

So, I checked the PR files and I realized there is no fix for the Ignore Rows itself, but limiting the terraform to 5.0. I have other terraform-aws they already upgraded the constraints to >5.0.0 and that force me to move to a newer version.

Anyway, thanks for the prompt answer.

I will try to take a look and adjust the module, so it's compatible with aws provider 5.0.0 and above. Let's see.

[scadu]

With the current example, https://github.com/clowdhaus/terraform-aws-msk-kafka-cluster/pull/4 would need to get merged as EBS-related configuration for aws_msk_cluster resource were also moved.

[igorjanevski]

Can you guys provide ETA for the fix? We are stuck with this and need it to work with 5.0

[brunodasilvalenga]

Hey guys, any chances to someone approve the PR?

[github-actions[bot]]

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

[siourdas-vasilis]

Any updates on that????

[scadu]

Looks like https://github.com/terraform-aws-modules/terraform-aws-dms/pull/42 is the more complete one, but it's marked as a draft for now.

[antonbabenko]

This issue has been resolved in version 2.0.0 :tada:

[github-actions[bot]]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.