feat!: Update AWS provider to support `v5.0` and increase Terraform MSV to `1.0`

bryantbiggs commented 1 year ago

Description

Update AWS provider to support v5.0 and increase Terraform MSV to 1.0
Add support for creating IAM access role
Remove s3_settings from aws_dms_endpoint and use aws_dms_s3_endpoint instead per AWS provider direction
Add support for redshift_settings on aws_dms_endpoint

Motivation and Context

Resolves #38
Resolves #40
Resolves #41
Resolves #43

Breaking Changes

Yes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

bryantbiggs commented 1 year ago

pending testing and validation

bryantbiggs commented 1 year ago

this is already addressed https://github.com/bryantbiggs/terraform-aws-dms/blob/2bdf65d892f36e40bfdea884e7f5c0d9e262732d/main.tf#L338

brunodasilvalenga commented 1 year ago

Hey @bryantbiggs any changes to have it approved? I'm looking to the fix of "ignore_header_rows".

antonbabenko commented 1 year ago

This PR is included in version 2.0.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-dms