terraform-aws-modules / terraform-aws-dms

Terraform module to create AWS DMS (Database Migration Service) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/dms/aws
Apache License 2.0
60 stars 93 forks source link

Examples have stopped working #43

Closed cslattery117 closed 11 months ago

cslattery117 commented 1 year ago

Description

This is due to a provider change to 5.0 See https://www.reddit.com/r/Terraform/comments/13uc728/an_issue_with_terraform_module_320/

Fix is to push the AWS provider version to 5.0, but this then brings a second issue with EBS volume size being removed from the Kafka provider.

Recommend these be revisited to update the example to work with current providers, please.

thanks.

Should not be too difficult !

cslattery117 commented 1 year ago

Yes

  1. Update aws provider to 5.0
  2. Update MSK cluster to 2.1.0 as per latest version and remove ebs vol size
  3. change scram config wording

now terraform plan works

github-actions[bot] commented 11 months ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 11 months ago

This issue was automatically closed because of stale in 10 days

antonbabenko commented 11 months ago

This issue has been resolved in version 2.0.0 :tada:

github-actions[bot] commented 10 months ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.