chore!: change IAM names to dynamic

YusDyr commented 10 months ago

Description

Instead of use predefined IAM names which could lead to confusing when there are few projects in the same AWS account, I suggest to use name_prefix to generate unique per-project names for these resources.

Motivation and Context

Imagine you create more than 1 project in a AWS account. Currently, because IAM resources have hardcoded names, it's impossible to make multiple projects - you'll have an error "such aws resource already exists". With proposed changes, we eliminate the issue.

Breaking Changes

It breaks backwards compatibility just in terms of recreate IAM resources with new names.

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects
[ ] I have executed pre-commit run -a on my pull request

YusDyr commented 10 months ago

The same issue was here: https://github.com/terraform-aws-modules/terraform-aws-dms/issues/32

bryantbiggs commented 10 months ago

Please read the docs - the exact names shown are required by DMS

github-actions[bot] commented 9 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-dms