feat: We make role names variable (#1)

terraform-aws-modules / terraform-aws-dms

Terraform module to create AWS DMS (Database Migration Service) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/dms/aws

Apache License 2.0

60 stars 93 forks source link

feat: We make role names variable (#1) #59

Closed Donnie closed 5 months ago

Donnie commented 5 months ago

Description

Adding variables in IAM Role names

Motivation and Context

We have multiple DMS instances for multiple teams, and they would like their IAM Roles to be separate.

Breaking Changes

No breaking changes, however care needs to be taken if the repl_instance_id is being used.

How Has This Been Tested?

We have tested it through usage.

bryantbiggs commented 5 months ago

https://docs.aws.amazon.com/dms/latest/userguide/security-iam.html#CHAP_Security.APIRole

github-actions[bot] commented 4 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.