search

terraform-aws-modules / terraform-aws-dms

Terraform module to create AWS DMS (Database Migration Service) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/dms/aws
Apache License 2.0
62 stars 94 forks source link

fix: Add subnet group dependency on IAM resources #7

Closed henworth closed 2 years ago

henworth commented 2 years ago

Description

As explained in the linked issue, there is a race condition when creating the subnet group before the IAM resources have been created.

Motivation and Context

Fixes #6

How Has This Been Tested?

Observed the following failure occurring on an initial run of the module:

Error: AccessDeniedFault: The IAM Role arn:aws:iam::REDACTED:role/dms-vpc-role is not configured properly.

with module.dms[0].aws_dms_replication_subnet_group.this[0]
on .terraform/modules/dms/main.tf line 89, in resource "aws_dms_replication_subnet_group" "this":
resource "aws_dms_replication_subnet_group" "this" {

Made this change in a fork of this module, observed the failure no longer occurring. However, I did not test (because I was not able to) deleting this IAM role and re-running.

Screenshots (if appropriate):

bryantbiggs commented 2 years ago

:tada: This PR is included in version 1.0.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.