search

terraform-aws-modules / terraform-aws-dms

Terraform module to create AWS DMS (Database Migration Service) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/dms/aws
Apache License 2.0
62 stars 94 forks source link

fix: declare endpoints output as sensitive #9

Closed henworth closed 2 years ago

henworth commented 2 years ago

Description

In Terraform version 0.14 and above, module outputs with sensitive keys need to be marked as sensitive. Currently, this module will error out with this message:

│ Error: Output refers to sensitive values
│
│   on outputs.tf line 84:
│   84: output "endpoints" {
│
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true
╵

Motivation and Context

Allows apply to complete on Terraform 0.14 and above.

How Has This Been Tested?

Initially observed a Terraform apply fail with the above error message. Once this change was made, the apply was allowed to complete.

Screenshots (if appropriate):

bryantbiggs commented 2 years ago

:tada: This PR is included in version 1.0.5 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.