Closed ehassett closed 2 years ago
@ethanhassett Could you please rebase it? We have released v3.0.0 a few hours ago where some of your code should be updated.
Accidentally closed this PR with a force-push, reworking the code for v3.0 and will update soon.
PR updated with changes for 3.0 as there is no longer instace_count support. This has been tested with module.ec2_complete_ebs_volume_resource
that I've added to examples/complete/main.tf
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
This PR was automatically closed because of stale in 10 days
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
This PR aims to enable the optional use of
aws_ebs_volume
andaws_volume_attachment
resources as opposed to the inlineebs_block_device
dynamic block. It improves upon similar open PRs (#186 and #140) in the following ways:var.ebs_block_device
and manipulates it through a local for use with the separate resource blocks.count
in the volume resources, and therefore those resources are unordered and can be added/removed/changed without breaking other volumes.var.volume_tags
.Motivation and Context
This PR solves limitations prevented by using an inline EBS block in the
aws_instance
resource.Breaking Changes
N/A
How Has This Been Tested?
examples/*
projectsTested with the complete example by adding
use_ebs_volume_resource = true
to the inputs.