terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws
Apache License 2.0
758 stars 1.88k forks source link

feat: Add support for EBS GP3 throughput #233

Closed schniber closed 3 years ago

schniber commented 3 years ago

Fixes #226

Description

Added the mapping of throughput in the dynamic root block and ebs block device objects

Motivation and Context

This will allow to provision gp3 volumes with the capacity to define the required throughput

Breaking Changes

No breaking changes foreseen. I did not implement checks on volume type since the AWS API will error out in case this is specified for a non gp3 ebs volume.

How Has This Been Tested?

Error: error collecting instance settings: error creating resource: throughput attribute not supported for ebs_block_device with volume_type gp2

Please feel free to provide your feedback I'd be happy to take it into account.

Thanks.

Bests.

antonbabenko commented 3 years ago

Looks good.

Please fix formatting by running pre-commit run -a.

schniber commented 3 years ago

Pre-commit hooks run and all clear ! Thanks for the feedback ! Bests.

antonbabenko commented 3 years ago

Ok, I fixed the docs. You used to use terraform-docs v0.13.0.

antonbabenko commented 3 years ago

v2.21.0 has been just released.

schniber commented 3 years ago

Perfect thanks a lot ! Sorry for the iterations this is my first Pull Request :) Good luck and keep up the awesome work overall !

github-actions[bot] commented 2 years ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.