Closed schniber closed 3 years ago
Looks good.
Please fix formatting by running pre-commit run -a
.
Pre-commit hooks run and all clear ! Thanks for the feedback ! Bests.
Ok, I fixed the docs. You used to use terraform-docs v0.13.0.
v2.21.0 has been just released.
Perfect thanks a lot ! Sorry for the iterations this is my first Pull Request :) Good luck and keep up the awesome work overall !
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Fixes #226
Description
Added the mapping of throughput in the dynamic root block and ebs block device objects
Motivation and Context
This will allow to provision gp3 volumes with the capacity to define the required throughput
Breaking Changes
No breaking changes foreseen. I did not implement checks on volume type since the AWS API will error out in case this is specified for a non gp3 ebs volume.
How Has This Been Tested?
examples/*
projects I have changed the basic example to have it deploy gp3 volumes for the root and also for additional ebs and also included throughtput values. I have also tested a case where user input is incorrect ie setting volume type to gp2 and setting the throughput. => AWS API error is clear enough to guide the end user to correct his/her inputs :Error: error collecting instance settings: error creating resource: throughput attribute not supported for ebs_block_device with volume_type gp2
Please feel free to provide your feedback I'd be happy to take it into account.
Thanks.
Bests.