Tags are not created when create_spot_instance = true

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws

Apache License 2.0

758 stars 1.88k forks source link

Tags are not created when create_spot_instance = true #243

Closed prandelicious closed 3 years ago

prandelicious commented 3 years ago

Description

If create_spot_instance = true, tags are not created.

⚠️ Note

Versions

Terraform: v1.0.8
Provider(s): aws v3.62.0

Reproduction

Steps to reproduce the behavior:

Include create_spot_instance = true in the module: no tags created
Remove create_spot_instance from the module : tags are created

Code Snippet to Reproduce

Expected behavior

Actual behavior

Tags are not created when create_spot_instances = true

Terminal Output Screenshot(s)

Additional context

It appears this issue is with the AWS provider and was initially reported back in 2015 but wasn't fixed by Hashicorp.

antonbabenko commented 3 years ago

Hi!

As you point out there was an open issue in Terraform AWS provider and we can't do anything about it in the module.

prandelicious commented 3 years ago

Perhaps add this information to the documentation as a warning so people don't expect this functionality to work?

antonbabenko commented 3 years ago

I don't think it makes sense for this module to sync issues and track features available in Terraform AWS provider.

github-actions[bot] commented 2 years ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.