Fix Ignore Subnet ID - Githubissues

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws

Apache License 2.0

754 stars 1.87k forks source link

Fix Ignore Subnet ID #262

Closed alisonjenkins closed 2 years ago

alisonjenkins commented 2 years ago

Do not recreate the instance if the subnet ID changes. This is because the data.aws_subnet_ids data source has been deprecated and the replacement does not return the subnets in the same order.

antonbabenko commented 2 years ago

Don't use data.aws_subnet_ids data source...

This PR is not going to be merged because it does not satisfy everyone's needs and Terraform doesn't allow usage of variables in lifecycle block.

alisonjenkins commented 2 years ago

@antonbabenko sorry I did not actually mean to open it against the public version of this module.

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.