feat: Add support for `disable_api_stop` attribute

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws

Apache License 2.0

754 stars 1.87k forks source link

feat: Add support for `disable_api_stop` attribute #275

Closed msharma24 closed 2 years ago

msharma24 commented 2 years ago

Description

Added disable_api_stop action attribute to the ec2 instance resource - Supported in latest TF Provider release 4.20.0

Motivation and Context

To prevent your instance from being accidentally stopped, you can enable stop protection for the instance.

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

bryantbiggs commented 2 years ago

Looks good and almost there - just need to update the min supported provider version to 4.20 and update the wrappers (will autoupdate if you install hcledit and run pre-commit)

msharma24 commented 2 years ago

@bryantbiggs Thanks . I have updated the versions.tf and wrappers/main.tfwith pre-commit run -a

msharma24 commented 2 years ago

@bryantbiggs looks good ?

bryantbiggs commented 2 years ago

you have a failing CI check - you need to run pre-commit run -a

msharma24 commented 2 years ago

@bryantbiggs 👍

pre-commit run -a
Terraform fmt............................................................Passed
Terraform wrapper with for_each in module................................Passed
Terraform validate.......................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed

antonbabenko commented 2 years ago

This PR is included in version 4.1.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.