fix: Revert capacity_reservation_specification default value from {} to null

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws

Apache License 2.0

754 stars 1.87k forks source link

fix: Revert capacity_reservation_specification default value from {} to null #287

Closed schniber closed 2 years ago

schniber commented 2 years ago

Description

This fix in order to revert back the capacity_reservation_specification default value from {} to null which was causing issues for plans.

Motivation and Context

Fixing regression introduced in 4.1.3

Breaking Changes

None.

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

schniber commented 2 years ago

fixes #286. I ran the complete example locally and I validated the fix. ready for review.

@bryantbiggs

antonbabenko commented 2 years ago

This issue has been resolved in version 4.1.4 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.