terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws
Apache License 2.0
754 stars 1.87k forks source link

Enable tags for ebs_block_device #306

Closed srinivassambari1 closed 1 year ago

srinivassambari1 commented 1 year ago

Description

aws_instance resource has ebs_block_device block which offers to add tags, current module is ignored the optional tags argument for this block.

Tags are useful while creating backup of EBS volumes through AWS BACKUP Service as Tag based backup solution.

please refer supported resources of AWS Backup service at here https://docs.aws.amazon.com/aws-backup/latest/devguide/whatisbackup.html

please refer https://docs.aws.amazon.com/aws-backup/latest/devguide/assigning-resources.html for tag based resource assignment for a backup plan

Versions

Reproduction Code [Required]

pls refer optional arguement - tags at https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/instance#ebs-ephemeral-and-root-block-devices

Steps to reproduce the behavior: compare below code with the above link to identify optional tags argument is missing.

https://github.com/terraform-aws-modules/terraform-aws-ec2-instance/blob/master/main.tf#L78

Expected behavior

Enable users to supply tags for ebs_block_device so that it is useful to backup EBS volumes through tag based backup plans through AWS Backup service.

Actual behavior

optional tags argument is missing in ebs_block_device block

srinivassambari1 commented 1 year ago

I am closing this issue, just realised that this can be achieved by using volume_tags variable.

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.