search

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws
Apache License 2.0
754 stars 1.87k forks source link

Change instance type to t3.micro to not trip users up on pricing and be friendly to free tier #307

Closed h4sh5 closed 1 year ago

h4sh5 commented 1 year ago

Description

Change instance type to t3.micro to not trip users up on pricing and be friendly to free tier

Motivation and Context

Users of example terraform code could be new to AWS, and have no idea about the cost behind large instance types.

Using c5.xlarge and c5.large instance types can trip users up with unexpected costs.

Breaking Changes

Shouldn't break anything

How Has This Been Tested?

It hasn't, insufficient changes needed for testing imo - but feel free to do it

bryantbiggs commented 1 year ago

thank you but this is an example and its up to users to know what is being provisioned. sometimes certain instance types are required based on the configuration used

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.