feat: Add support for `maintenance_options`

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws

Apache License 2.0

754 stars 1.87k forks source link

feat: Add support for `maintenance_options` #312

Closed magreenbaum closed 1 year ago

magreenbaum commented 1 year ago

Description

Adding auto_recovery option to toggle between default and disabled. This argument is computed if not configured. https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ec2-instance-recover.html

Motivation and Context

Resolves #310

Breaking Changes

No.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

bryantbiggs commented 1 year ago

Ugh, GitHub changed something with the rate limiting and now our actions are failing early. Give me a sec to fix these with a token - changes look good and we'll be able to merge straight away

antonbabenko commented 1 year ago

This PR is included in version 4.3.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.