terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws
Apache License 2.0
754 stars 1.87k forks source link

Optionally use aws_ebs_volume and aws_volume_attachment instead of dynamic ebs_block_device volume #317

Closed landrew57 closed 1 year ago

landrew57 commented 1 year ago

Raising a repeat of #263 hoping to reopen the discussion. I don't think it's worth sharing all of the same details again as that ticket is quite extensive, and the PR raised in #266 looks good to me. Unfortunately I can't reopen that issue or PR once they have been closed as stale.

Is there a reason that the proposed solution is a bad idea and/or not desired? It would be good to understand it if there is.

We are currently implementing the solution from the volume attachment examples, but it would be great to have that setup supported natively in the module.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

This issue was automatically closed because of stale in 10 days

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.