search

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws
Apache License 2.0
754 stars 1.87k forks source link

feat:Addition of block device information in outputs #318

Closed schniber closed 1 year ago

schniber commented 1 year ago

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

Is your request related to a problem? Please describe.

Ideally the module shout output the block device information that it was able to create. This is useful specially to retrieve the volume IDs in case we'd like to make use of it (for eg to create Cloudwatch Alarms to monitor the volumes)

Describe the solution you'd like.

The module should be able to output the block device information (most importantly the volume ids since the other attributes are provided in the inputs)

Describe alternatives you've considered.

None

Additional context

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 10 days

github-actions[bot] commented 1 year ago

This issue was automatically closed because of stale in 10 days

schniber commented 1 year ago

@bryantbiggs: hello ! is it possible to reopen this issue that got stale ? I provided a fix also and looking forward for a peer review. Thanks in advance. Bests

antonbabenko commented 1 year ago

This issue has been resolved in version 4.4.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.