feat: Addition of block device information in outputs

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws

Apache License 2.0

754 stars 1.87k forks source link

feat: Addition of block device information in outputs #319

Closed schniber closed 1 year ago

schniber commented 1 year ago

Description

This PR adds the block device information in the outputs of the module (for the root, ebs block and also ephemeral devices)

Motivation and Context

The motivation is to expose the Volume IDs that are created through this module. This would allow users willing to create Cloudwatch Monitoring for these EBS volumes to acheive this programatically. This PR fixes: #318

Breaking Changes

How Has This Been Tested?

[X] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

schniber commented 1 year ago

Hello @bryantbiggs !

This PR is ready for peer review. Thanks a lot.

Bests.

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

schniber commented 1 year ago

This comment to avoid this to be marked as stale. Thanks.

schniber commented 1 year ago

This comment to avoid this to be marked as stale. Thanks.

antonbabenko commented 1 year ago

This PR is included in version 4.4.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.