Closed kevingunn-wk closed 1 year ago
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days
Not stale - would still be nice to see this merged so that AMI Ids are not flagged as sensitive.
This PR is included in version 4.3.1 :tada:
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
When running
terraform plan
- theami
is hidden and marked as sensitive. This happens whether or not an AMI Id is provided orami_ssm_parameter
is used. This is becauseaws_ssm_parameter
value is by default a sensitive value.Example:
Motivation and Context
When running
terraform plan
, it would be nice to know the AMI ID, especially when areplace
is triggered. If I am replacing the instance because of an AMI change, I want to make sure the correct AMI ID is being used. This is especially helpful when usingami_ssm_parameter
, to make sure the correct paramter value is used.I also think it might be useful to include the AMI as the output. When using
ami_ssm_parameter
, the actual AMI Id is not obvious, so including it in the output makes it easy to identify which AMI was used from the parameter store.Breaking Changes
N/A
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull requestRan
terraform plan
after making the change