bump versions.tf for module 4.3.1

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws

Apache License 2.0

758 stars 1.88k forks source link

bump versions.tf for module 4.3.1 #330

Closed silvaalbert closed 1 year ago

silvaalbert commented 1 year ago

Description

Please update versions.tf to reflect a requirement for Terraform version 0.15.0 or greater. The new nonsensitive function requires that version. Given that this is a breaking change, perhaps it should have been a major release.

https://developer.hashicorp.com/terraform/language/functions/nonsensitive

[X] ✋ I have searched the open/closed issues and my issue is not listed.

⚠️ Note

Versions

Module version [Required]: 4.3.1
Terraform version: < 0.15.0

dbpyle184 commented 1 year ago

Given that this is a possible breaking change for anyone running TF prior to v15.0. Could the update to move to using the nonsentive function be reverted and released in a Major change IE 5.x.x?

AdamTylerLynch commented 1 year ago

@antonbabenko this change caused an impact for one of our customers.

antonbabenko commented 1 year ago

@bryantbiggs Should we bump versions.tf to require Terraform 1.0+ in this module, also?

bryantbiggs commented 1 year ago

yes, we can do this in #331 - just want to check a few other things first

antonbabenko commented 1 year ago

This issue has been resolved in version 5.0.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.