feat!: Raise minimum required Terraform version to 1.0+

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws

Apache License 2.0

758 stars 1.88k forks source link

feat!: Raise minimum required Terraform version to 1.0+ #331

Closed bryantbiggs closed 1 year ago

bryantbiggs commented 1 year ago

Description

Raise minimum required Terraform version to 1.0+
Add support for ignoring changes to the instances AMI ID; this does not apply to the spot instance since that is less applicable to living for a long duration
Update default metadata_options to enforce IMDSv2 for stronger security posture
Update t-type logic to account for t4g instance type

Motivation and Context

Resolves #325
Resolves #330

Breaking Changes

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

antonbabenko commented 1 year ago

This PR is included in version 5.0.0 :tada:

dhoppe commented 1 year ago

@bryantbiggs Has this been tested with the new variable ignore_ami_changes? I get the following error message, but only if the value of this variable is set to true.


╷
│ Error: Output refers to sensitive values
│
│   on outputs.tf line 146:
│  146: output "ami" {
│
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true
╵
`´´

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.