search

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws
Apache License 2.0
754 stars 1.87k forks source link

cpu_core_count and cpu_threads_per_core attributes deprecation in favor of the cpu_options block #332

Closed schniber closed 1 year ago

schniber commented 1 year ago

Description

Terraform AWS Provider v4.66 deprecates the use of cpu_core_count and cpu_threads_per_core attributes at the aws_instance level which displays deprecation warnings when running the examples delivered with this module.

If your request is for a new feature, please use the Feature request template.

Versions

Reproduction Code [Required]

Run the complete example as per this TF module.

Steps to reproduce the behavior:

Expected behavior

Terraform plan and apply execute without deprecation warnings.

Actual behavior

│ Warning: Argument is deprecated │ │ with module.ec2_complete.aws_instance.this[0], │ on ../../main.tf line 24, in resource "aws_instance" "this": │ 24: cpu_core_count = var.cpu_core_count │ │ use 'cpu_options' argument instead │

Terminal Output Screenshot(s)

Additional context

antonbabenko commented 1 year ago

This issue has been resolved in version 5.1.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.