terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws
Apache License 2.0
758 stars 1.88k forks source link

feat: Implementation of the cpu_options block and addition of support for AMD SEV-SNP #334

Closed schniber closed 1 year ago

schniber commented 1 year ago

Description

I have implemented the fix for the deprecation warning of cpu_core_count and cpu_threads_per_core attributes. Those can now be specified using the cpu_options block.

In addition, this PR adds the support for AMD SEV-SNP which is also a new attribute that can be set via the cpu_options block.

Motivation and Context

Breaking Changes

Yes, customers can no longer use the cpu_core_count and cpu_threads_per_core variables anymore. Those have been removed in favor of a new variable cpu_options that can be used as below:

cpu_options = {
    core_count       = 2
    threads_per_core = 1
}

How Has This Been Tested?

antonbabenko commented 1 year ago

This PR is included in version 5.1.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.