feat: Add example for connecting via Session Manager without Internet access

terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws

Apache License 2.0

754 stars 1.87k forks source link

feat: Add example for connecting via Session Manager without Internet access #336

Closed luigidifraiawork closed 1 year ago

luigidifraiawork commented 1 year ago

Description

Add an example demonstrating how an EC2 instance not connected to the Internet can be accessed using Session Manager through VPC Endpoints.

Motivation and Context

I thought to provide the open-source community with a working example for the above-mentioned scenario.

Breaking Changes

None.

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

luigidifraiawork commented 1 year ago

@antonbabenko Is there anything I can help with in order to facilitate a review of this pull request, please? I am happy to keep rebasing it in the meantime.

github-actions[bot] commented 1 year ago

This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days

luigidifraiawork commented 1 year ago

Not stale.

antonbabenko commented 1 year ago

This PR is included in version 5.5.0 :tada:

luigidifraiawork commented 1 year ago

awesome, thank you!

You're welcome. Thank you for reviewing, approving and making this example part of the module.

github-actions[bot] commented 12 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.