terraform-aws-modules / terraform-aws-ec2-instance

Terraform module to create AWS EC2 instance(s) resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ec2-instance/aws
Apache License 2.0
754 stars 1.87k forks source link

feat: Add input variable 'instance_tags' #343

Closed luigidifraiawork closed 1 year ago

luigidifraiawork commented 1 year ago

Description

Add input variable instance_tags, similarly to the VPC module's vpc_tags.

Motivation and Context

It allows for fine grained tagging of EC2 instances that can be used by automation tools to perform certain actions, such as cost-saving measures by shutting down instances outside of working hours if they are tagged with e.g., Persistence = "09:00-18:00". With this change in place, the extra instance tag would not be set for the volume or IAM role but just for the instance itself, which is the only place where it makes sense.

Breaking Changes

None.

How Has This Been Tested?

antonbabenko commented 1 year ago

This PR is included in version 5.2.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.