fix: Modify coalesce ami and ami_ssm_parameter function from always failing when ami var defined

Zonny commented 1 year ago

… always failing when ami var defined

Description

Include separate try functions for both var.ami and nonsensitive(data.aws_ssm_parameter.this[0].value) to allow them to return null separately instead of returning null if the whole expression fails

Motivation and Context

Change is required to fix #352

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s) (Note: I don't believe I need to make any changes to the examples for this PR)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

antonbabenko commented 1 year ago

This has been resolved in #354

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

terraform-aws-modules / terraform-aws-ec2-instance