feat: Added ecr:GetAuthorizationToken for private ECR with Docker capabilities

terraform-aws-modules / terraform-aws-ecr

Terraform module to create AWS ECR resources 🇺🇦

https://registry.terraform.io/modules/terraform-aws-modules/ecr/aws

Apache License 2.0

52 stars 111 forks source link

feat: Added ecr:GetAuthorizationToken for private ECR with Docker capabilities #12

Closed good92 closed 2 years ago

good92 commented 2 years ago

Fixed private ECR policy to allow Docker capabilities. Could be improved with an input variable for docker_capability activation.

Description

Added ecr:GetAuthorizationToken policy for private ECR with Docker capabilities

Motivation and Context

Using the ECR as private with as Docker (OCI) registry.

Breaking Changes

Adds a not needed policy for the private ECR when not used for Docker.

How Has This Been Tested?

Ongoing

antonbabenko commented 2 years ago

This PR is included in version 1.5.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.