search

terraform-aws-modules / terraform-aws-ecr

Terraform module to create AWS ECR resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ecr/aws
Apache License 2.0
52 stars 109 forks source link

feat: Add new variable for allowing ECR image sharing to lambda service in external account #16

Closed thepoppingone closed 1 year ago

thepoppingone commented 1 year ago

This is extensible to other services like codebuild, however I only require lambda image to be shared to the lambda service of another for now

Description

Introduce another variable to allow ARN of lambda functions ARNs to be stated

Motivation and Context

Currently, the module hard codes the principal value to "AWS" only. Hence I am not able to use it for other services despite this option of inserting services to be included the policy statement being present in the AWS console More docs here: https://aws.amazon.com/blogs/compute/introducing-cross-account-amazon-ecr-access-for-aws-lambda/

Also this module consolidates all statements into a single policy, I cannot work around it but to add to it to handle for lambda case instead.

Breaking Changes

None

How Has This Been Tested?

It uses a variable with a default value of [] that will not trigger the dynamic statement

antonbabenko commented 1 year ago

This PR is included in version 1.6.0 :tada:

github-actions[bot] commented 1 year ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.