search

terraform-aws-modules / terraform-aws-ecr

Terraform module to create AWS ECR resources 🇺🇦
https://registry.terraform.io/modules/terraform-aws-modules/ecr/aws
Apache License 2.0
52 stars 111 forks source link

feat: Variable repository_lambda_read_access added #21

Closed akoshel closed 10 months ago

akoshel commented 10 months ago

Description

ECR lambda access policy for private repositories.

Motivation and Context

The current implementation of repository_lambda_read_access_arns necessitates a list of Lambda service role ARNs, but this requirement is not essential. https://github.com/terraform-aws-modules/terraform-aws-ecr/blob/master/main.tf#L67C52-L67C102 https://docs.aws.amazon.com/lambda/latest/dg/images-create.html

Changes

Added new variable bool repository_lambda_read_access to set lambda access ecr policy repository_lambda_read_access_arns will work as before, description updated as deprecated variable

bryantbiggs commented 10 months ago

it is correct as written - this is intended to support cross account permissions as well

github-actions[bot] commented 9 months ago

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.